Skip to content

feat: Unit align sidebar [FC-0114]#2856

Merged
ChrisChV merged 5 commits intoopenedx:masterfrom
open-craft:chris/FAL-4304-unit-align-sidebar
Feb 13, 2026
Merged

feat: Unit align sidebar [FC-0114]#2856
ChrisChV merged 5 commits intoopenedx:masterfrom
open-craft:chris/FAL-4304-unit-align-sidebar

Conversation

@ChrisChV
Copy link
Contributor

@ChrisChV ChrisChV commented Jan 31, 2026 •
edited
Loading

Description

  • Implements the align sidebar in the unit page for the unit and components
  • Which user roles will this change impact? "Course Author"
image

Supporting information

Testing instructions

  • Create a new unit in a course.
  • Verify that you can open the align sidebar using the navbar on the right.
  • Verify that you can add tags for the unit
  • Add new components to the unit
  • Click in the Manage tags menu of a component.
  • Verify that the align sidebar is opened for the component.

Other information

N/A

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Avoid propTypes and defaultProps in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Avoid using ../ in import paths. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

@openedx-webhooks
Copy link

openedx-webhooks commented Jan 31, 2026 •
edited
Loading

Thanks for the pull request, @ChrisChV!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 31, 2026
@ChrisChV ChrisChV marked this pull request as draft January 31, 2026 02:09
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Jan 31, 2026
@codecov
Copy link

codecov bot commented Jan 31, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 97.82609% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.22%. Comparing base (2d5421e) to head (d456682).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/course-unit/unit-sidebar/UnitAlignSidebar.tsx 94.11% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           master    #2856    +/-   ##
========================================
  Coverage   95.22%   95.22%            
========================================
  Files        1328     1330     +2     
  Lines       30510    30544    +34     
  Branches     6884     6676   -208     
========================================
+ Hits        29053    29086    +33     
- Misses       1400     1401     +1     
  Partials       57       57

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ChrisChV ChrisChV marked this pull request as ready for review February 2, 2026 17:48
@bradenmacdonald
Copy link
Contributor

bradenmacdonald commented Feb 2, 2026

@ChrisChV Can you please rebase this and we can see if the new oxlint checks are working?

@ChrisChV
Copy link
Contributor Author

ChrisChV commented Feb 2, 2026

@ChrisChV Can you please rebase this and we can see if the new oxlint checks are working?

Sure. Done 👍

@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Feb 3, 2026
@mphilbrick211 mphilbrick211 moved this from Needs Triage to In Eng Review in Contributions Feb 3, 2026
navinkarkera
navinkarkera approved these changes Feb 13, 2026
View reviewed changes
Copy link
Contributor

@navinkarkera navinkarkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisChV Looks good!

bradenmacdonald
bradenmacdonald approved these changes Feb 13, 2026
View reviewed changes
Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/course-unit/xblock-container-iframe/index.tsx
const handleOpenManageTagsModal = (id: string) => {
setConfigureXBlockId(id);
openManageTagsModal();
if (isUnitPageNewDesignEnabled()) {
Copy link
Contributor

@bradenmacdonald bradenmacdonald Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a ticket planned to remove all these if (isUnitPageNewDesignEnabled()) { ?

Copy link
Contributor Author

@ChrisChV ChrisChV Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll create one. Thanks!

@ChrisChV ChrisChV merged commit 4d401a9 into openedx:master Feb 13, 2026
8 checks passed
@github-project-automation github-project-automation bot moved this from In Eng Review to Done in Contributions Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bradenmacdonald bradenmacdonald bradenmacdonald approved these changes

+1 more reviewer

@navinkarkera navinkarkera navinkarkera approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Contributions
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ChrisChV @openedx-webhooks @bradenmacdonald @navinkarkera @mphilbrick211